Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding willConfigure & didConfigure methodes to delegate #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Idomo
Copy link
Contributor

@Idomo Idomo commented Jan 23, 2019

Like I explained in #9, I was able to make those work after running "Clean Build Folder" from "Product" menu in xCode.

  • If you know how - you may want to make those 2 new methods optional, 'cause they're not must.
  • If there is need for something like DispatchQueue.global(qos: .userInitiated).async that you've included in the other calls for the delegate methods, you may add it (I didn't know if this is related to the cropping itself or to the delegate methods).

Thanks,
Ido.

Like I explained in jonasbeckers#9, I was able to make those work after running "Clean Build Folder" from "Product" menu in xCode.
- If you know how - you may want to make those 2 new methods optional, 'cause they're not must.
- If there is need for something like `DispatchQueue.global(qos: .userInitiated).async` that you've included in the other calls for the delegate methods, you may add it (I didn't know if this is related to the cropping itself or to the delegate methods).

Thanks,
Ido.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant